[docs] Add explanation for using font icon in a local project #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahrukh-Zindani
commented
Feb 20, 2017
•
Shahrukh-Zindani
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
…font icon in a local project
oliviertassinari
changed the title
oliviertassinari
approved these changes
Feb 20, 2017
oliviertassinari
changed the title
oliviertassinari
added
docs
mbrookes
changed the title
mbrookes
added
PR: needs revision
|
The linked article:
|
|
I had no idea of how to use font icon until I read this article. The intention was to make it easy for users to be able to use font icons quickly in their projects. |
|
Changed the article link to a different article which looks good to me. |
|
Perhaps something more authoritative than a random blog post? http://google.github.io/material-design-icons/#icon-font-for-the-web |
mbrookes
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
requested changes
Feb 21, 2017
| @@ -4,7 +4,7 @@ This component will render any [icon](https://www.google.com/design/spec/style/i | |||
| defined in any stylesheet included in your project. You can use sites like [IcoMoon](https://icomoon.io/) | |||
| to generate custom font files, or use prebuilt fonts such as [Material icons](https://design.google.com/icons/) or | |||
| [Font Awesome](http://fontawesome.io/) either included in your project, or served from a public | |||
| [Content Delivery Network](https://en.wikipedia.org/wiki/Content_delivery_network). | |||
| [Content Delivery Network](https://en.wikipedia.org/wiki/Content_delivery_network). Refer to this [article](http://google.github.io/material-design-icons/#icon-font-for-the-web) to learn how to use font icons from any of the above websites in your project. | |||
There was a problem hiding this comment.
Why is this affecting the CDN line?
There was a problem hiding this comment.
Might have been copied and pasted. Will be careful about it. It does not change the look though as that line was added back.
There was a problem hiding this comment.
Please use a line break. Having a line > 100 character is bad for readability & collaboration.
oliviertassinari
added
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.