Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Fix disabled MenuItem with props.menuItemStyle #6203

Merged
merged 2 commits into from
Feb 22, 2017
Merged

[Menu] Fix disabled MenuItem with props.menuItemStyle #6203

merged 2 commits into from
Feb 22, 2017

Conversation

tomchentw
Copy link

Hi,

I've fixed the issue that Menu.props.menuItemStyle not merged with disabled MenuItem children. I also added a failing test case first:

screen shot 2017-02-21 at 5 11 32 pm

Checklist

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added the component: menu This is the name of the generic UI component, not the React module! label Feb 21, 2017
@oliviertassinari oliviertassinari merged commit cb5fb2c into mui:master Feb 22, 2017
@oliviertassinari
Copy link
Member

Thanks for the test!

@tomchentw tomchentw deleted the fix/menu-item-disabled branch February 28, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomchentw @oliviertassinari @muibot