Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinearProgress] Reduce delay before indeterminate animation begins #6230

Conversation

lawrence-yu
Copy link

With how the indeterminate linear progress is currently implemented, when the animation is kicked off at componentDidMount, there's a one-time extra 420ms delay added on before we see the first bar go by (which, to me, makes it look like an abnormally long time before it starts - compared with the rest of the animation cycle once it gets going).

This change shaves off this delay while not altering the timing of the rest of the animation.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

… onto the next animation step. This lets us modify the initial call in componentDidMount to reduce the initial delay before animation begins.
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't noticed any visual difference, but I think you are right with the approach.

@oliviertassinari oliviertassinari changed the title [LinearProgress] For indeterminate, reduce delay before animation begins. [LinearProgress] Reduce delay before indeterminate animation begins Feb 24, 2017
@oliviertassinari oliviertassinari merged commit 33a7383 into mui:master Feb 25, 2017
@oliviertassinari
Copy link
Member

@lawrence-yu Thanks.

@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: LinearProgress The React component. component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants