[Button] Expose disableTouchRipple #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshalygin
force-pushed
the
feature/expose-raised-button-prop-disableTouchRippe
branch
from
0457788
to
40b92c8
Compare
muibot
added
PR: needs revision
oliviertassinari
requested changes
Feb 24, 2017
src/FlatButton/FlatButton.js
Outdated
| @@ -36,6 +36,10 @@ class FlatButton extends Component { | |||
| */ | |||
| className: PropTypes.string, | |||
| /** | |||
| * If true, the element's ripple effect will be disabled. | |||
| */ | |||
| disableTouchRipple: React.PropTypes.bool, | |||
There was a problem hiding this comment.
Prop types declarations should be sorted alphabetically react/sort-prop-types
oliviertassinari
added
component: RaisedButton
docs
- The enhanced button wrapper exposes an option to disable touch ripples. This is the case with the IconButton and should be persisted to the FlatButton. - In addition to exposing the prop, the documentation page will be automatically updated with the new prop for Icon Button as well, since the documentation for the props is pulled strictly from the FlatButton component
oshalygin
force-pushed
the
feature/expose-raised-button-prop-disableTouchRippe
branch
from
40b92c8
to
90ff625
Compare
- The enhanced button wrapper exposes the option to disable touch ripples. This is the case with the FlatButton component and should be exposed on RaisedButton for consistency. - In addition to exposing the prop, the documentation page will automatically be updated with the newly defined prop from the RaisedButton component
oshalygin
force-pushed
the
feature/expose-raised-button-prop-disableTouchRippe
branch
from
90ff625
to
956b29a
Compare
oliviertassinari
changed the title
oliviertassinari
added
component: FlatButton
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
approved these changes
Feb 25, 2017
|
@oshalygin Thanks, I have merged this PR and close the other one as RaisedButton & FlatButton are deeply linked. An atomic PR update sounds better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly references:
#6232
disable touch ripples. This is the case with the FlatButton
component and should be exposed on RaisedButton for consistency.
automatically with the newly defined prop from the RaisedButton Component.
Please wait to merge this until the previous PR is merged and this PR is rebased.