[TextField] sync height with shadow when rowsMax changed

[seasick]

This will adjust the height of the component when rowsMax property has changed.
Currently I am using this to expand the EnhancedTextarea when the element gains focus (and reset it when it blurs).

• PR has tests / docs demo, and is linted.
• Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
• Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

[oliviertassinari]

Thanks for taking the initiative to address the issue.

[oliviertassinari]

We shouldn't need that hook. componentWillReceiveProps should be enough.
I think that the issue is coming from syncHeightWithShadow using the old maxHeight value and not the up coming one. Does that makes sens for you?

[seasick]

Yes, the actual problem is, that syncHeightWithShadow is using this.props.rowsMax, which will contain the value before the property was changed. Thus the function also calculates the height for the old value.

This is the "culprit":

    if (this.props.rowsMax >= this.props.rows) {
      newHeight = Math.min(this.props.rowsMax * rowsHeight, newHeight);
    }

Another solution to this can be to call syncHeightWithShadow with an additional argument props and using them instead of this.props -- syncHeightWithShadow(newValue, event, props).

I think its a slightly better solution, since syncHeightWithShadow won't be called twice.

[oliviertassinari]

That looks good to me 👍