[RadioGroup] Add tests for edge cases #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Focus with no radios - Internal radios should fire onChange - on mount register internal radios to this.radios
muibot
added
PR: Needs Review
PR: needs revision
|
I'm not sure this still needs revision? |
|
@agamrafaeli Absolutely. "Needs revision" isn't removed automatically, as there may be other reasons "Needs revision" was added that aren't addressed by the most recent push. |
mbrookes
removed
the
PR: needs revision
oliviertassinari
requested changes
Mar 22, 2017
| before(() => { | ||
| mount = createMount(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We miss the teardown.
after(() => {
mount.cleanUp();
});
oliviertassinari
added
next
PR: needs revision
|
I'm gonna fix the issue once merged. |
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus with no radios
Internal radios should fire onChange
on mount register internal radios to this.radios
PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).