Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ripple] Add a new test for the unmount logic #6434

Merged
merged 1 commit into from Mar 26, 2017
Merged

[Ripple] Add a new test for the unmount logic #6434

merged 1 commit into from Mar 26, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 25, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #6410.

Use the fake timer test utils instead http://sinonjs.org/releases/v2.1.0/fake-timers/.

@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 25, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 25, 2017
@oliviertassinari oliviertassinari merged commit 038b00b into mui:next Mar 26, 2017
@oliviertassinari oliviertassinari deleted the next-test-ripple branch March 26, 2017 00:05
@@ -2,7 +2,8 @@

import React from 'react';
import { assert } from 'chai';
import { createShallow } from 'src/test-utils';
import { spy, useFakeTimers } from 'sinon';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants