Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui-icons] Reinstate README and update scripts, update installation.md #6448

Merged
merged 2 commits into from Mar 28, 2017
Merged

[material-ui-icons] Reinstate README and update scripts, update installation.md #6448

merged 2 commits into from Mar 28, 2017

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Mar 27, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

build/README.mdwas excluded in the last material-ui-icons PR, despite being explicitly included in .gitignore. Rather than force add it, I've moved it to the src directory, updated the build script to only rimraf the js files, and added the README to the list of files copied to the build directory.

The changes to package.json are mostly just a reordering of the scripts to alphabetical order.

I've also added a section on material-ui-icons to installation.md.

@mbrookes mbrookes changed the title [material-ui-icons] Reinstate README, and update scripts, update installation.md [material-ui-icons] Reinstate README and update scripts, update installation.md Mar 28, 2017
@mbrookes mbrookes merged commit da92446 into mui:next Mar 28, 2017
@mbrookes mbrookes deleted the next-material-ui-icons branch March 28, 2017 12:34
@zannager zannager added the package: icons Specific to @mui/icons label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants