Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Layout] Extract requireProp to utils #6473

Merged
merged 2 commits into from Mar 31, 2017
Merged

[Layout] Extract requireProp to utils #6473

merged 2 commits into from Mar 31, 2017

Conversation

agamrafaeli
Copy link
Contributor

@agamrafaeli agamrafaeli commented Mar 31, 2017 •
edited

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

requireProp() has logic that isn't proprietary to Layout. Also by extracting it I allowed for dedicated testing of its inner working.

oliviertassinari
oliviertassinari requested changes Mar 31, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rename src/utils/requireProp.spec.js to src/utils/requirePropFactory.spec.js ? Otherwise, that looks good to me 😄 .

@oliviertassinari oliviertassinari added next test PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Mar 31, 2017
@agamrafaeli
Copy link
Contributor Author

@oliviertassinari performed the rename. Could have gone either way. :)

@oliviertassinari oliviertassinari added PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 31, 2017
@mbrookes mbrookes merged commit 44fef24 into mui:next Mar 31, 2017
@mbrookes
Copy link
Member

@agamrafaeli Thanks - again! 👍 😄

@agamrafaeli agamrafaeli deleted the require-prop-factory branch April 1, 2017 11:15
@oliviertassinari oliviertassinari changed the title [Layout] extract requireProp to utils [Layout] Extract requireProp to utils Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agamrafaeli @mbrookes @oliviertassinari @muibot