Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Do not output any .map file #6478

Merged
merged 1 commit into from Apr 2, 2017
Merged

[core] Do not output any .map file #6478

merged 1 commit into from Apr 2, 2017

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I have noticed that we output a .map file. On the other hand, React for instance don't.

@mbrookes
Copy link
Member

mbrookes commented Apr 1, 2017

@oliviertassinari What are the pros and cons?

@oliviertassinari
Copy link
Member Author

The pros is simplicity and lighter npm release. I'm not aware of any cons.

@mbrookes mbrookes merged commit 4fd2bc2 into mui:next Apr 2, 2017
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliviertassinari @mbrookes @muibot @zannager