Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix import paths for theme and MuiThemeProvider #6493

Merged
merged 1 commit into from Apr 4, 2017
Merged

[test] Fix import paths for theme and MuiThemeProvider #6493

merged 1 commit into from Apr 4, 2017

Conversation

joefitzgerald
Copy link
Contributor

This is an extension of 444c603 and resolves three additional issues with import paths in test-utils.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@joefitzgerald
Fix test-utils paths for theme and MUIThemeProvider
0ff4df6 
Cannot find module 'src/styles/theme' from 'createMount.js'
      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:169:17)
      at Object.<anonymous> (node_modules/material-ui/test-utils/createMount.js:20:14)
oliviertassinari
oliviertassinari approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oliviertassinari oliviertassinari merged commit 8ecf76f into mui:next Apr 4, 2017
@joefitzgerald joefitzgerald deleted the jf-fix-test-utils branch April 5, 2017 15:19
@zannager zannager added test customization: theme Centered around the theming features labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
customization: theme Centered around the theming features test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joefitzgerald @oliviertassinari @muibot @zannager