[Popover] Add test for getoffset #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agamrafaeli
commented
Apr 5, 2017
•
agamrafaeli
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
| @@ -310,6 +310,8 @@ export default class Popover extends Component { | |||
| }; | |||
| } | |||
|
|
|||
| handleGetOffsetTop = getOffsetTop; | |||
There was a problem hiding this comment.
What about exporting the two functions instead of attaching them to the instance of the component?
I feel like it will be more explicit.
There was a problem hiding this comment.
The reason I went this way was that by exporting the functions we are declaring them to be "official" members of the component, in fact they are internal logical routers. From the perspective of writing tests absolutely exporting. From a program interface I think this is the better way to go. No?
oliviertassinari
added
next
PR: needs revision
oliviertassinari
approved these changes
Apr 5, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
|
@agamrafaeli Thanks once more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.