Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Improves borders behavior when scrollable #6576

Merged
merged 1 commit into from May 9, 2017

Conversation

bognix
Copy link

@bognix bognix commented Apr 11, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

When Dialog is scrollable show borders around its content only when content is bigger than calculated max height.
Address #4310.

@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! PR: Review Accepted bug 🐛 Something doesn't work and removed PR: Needs Review labels May 9, 2017
@oliviertassinari oliviertassinari merged commit b2d69b2 into mui:master May 9, 2017
@oliviertassinari
Copy link
Member

@bognix Sorry for the delay, thanks!

@oliviertassinari oliviertassinari changed the title [Dialog] Improves borders behavior in scrollable Dialog [Dialog] Improves borders behavior when scrollable May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants