[Chip] Add MuiChip to MUI_SHEET_ORDER #6595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placed the entry under MuiSvgIcon because MuiChip depends on it.
muibot
added
PR: Needs Review
PR: needs revision
oliviertassinari
requested changes
Apr 12, 2017
src/styles/MuiThemeProvider.js
Outdated
| @@ -35,6 +35,8 @@ export const MUI_SHEET_ORDER = [ | |||
| 'MuiSvgIcon', | |||
| 'MuiIcon', | |||
|
|
|||
| 'MuiChip', | |||
There was a problem hiding this comment.
I think that it should be after the MuiAvatar item of the array (higher priority)
mbrookes
changed the title
mbrookes
added
PR: Review Accepted
and removed
PR: needs revision
|
@nareshbhatia Thanks! |
|
Glad to be of help. Thanks to @oliviertassinari for suggesting the real fix. I just executed it :-) |
oliviertassinari
added
bug 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entry was missing. Placed it under MuiSvgIcon because MuiChip depends on it.