Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Fix controlled behavior #6638

Merged
merged 1 commit into from Apr 20, 2017
Merged

[Table] Fix controlled behavior #6638

merged 1 commit into from Apr 20, 2017

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #6006.
Closes #6295.

I some regards, this PR is introducing a breaking change by removing the ambiguity between default state and controlled state. Now, as soon as the selected property his used, the rows selection of the component are controlled. Hence fully implementing what's documented:

This property can be used to programmatically select rows.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! labels Apr 17, 2017
@oliviertassinari
Copy link
Member Author

I'm going ahead by merging this PR. It's a bug fix but will most likely change some people code behavior. I think that we should consider it a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant