Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Fix focus index when multiselect is used #6717

Merged
merged 1 commit into from Apr 29, 2017
Merged

[Menu] Fix focus index when multiselect is used #6717

merged 1 commit into from Apr 29, 2017

Conversation

jony89
Copy link
Contributor

@jony89 jony89 commented Apr 27, 2017 •
edited

trying to solve #6444 after #6460 has failed

  • getSelectedIndex changed to getLastSelectedIndex
  • if multiple select is used, don't use getLastSelectedIndex and keep current focus

@oliviertassinari oliviertassinari merged commit 7c85411 into mui:master Apr 29, 2017
@oliviertassinari
Copy link
Member

@jony89 Thanks!

@jony89
Copy link
Contributor Author

jony89 commented Apr 29, 2017 •
edited

I hope to contribute more in the future ! thanks for this great lib. :)

@oliviertassinari oliviertassinari changed the title fixing #6444 focus index on multiselect [Menu] Fix focus index when multiselect is used Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jony89 @oliviertassinari @muibot