Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breakpoints] up(‘xs’) should have a min-width of 0px #6735

Merged
merged 2 commits into from Apr 29, 2017
Merged

[breakpoints] up(‘xs’) should have a min-width of 0px #6735

merged 2 commits into from Apr 29, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Apr 29, 2017 •
edited

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This matches behavior of withWidth. Since xs is the smallest size, anything using up('xs') should be displayed.

@oliviertassinari oliviertassinari merged commit 8a3c5ba into mui:next Apr 29, 2017
rosskevin added a commit to alienfast/material-ui that referenced this pull request May 1, 2017
@rosskevin
[breakpoints] up(‘xs’) should have a min-width of 0px (mui#6735)
ae5ebbd 
* [breakpoints] up(‘xs’) should have a min-width of 0px

* formatting
rosskevin added a commit to alienfast/material-ui that referenced this pull request May 1, 2017
@rosskevin
[breakpoints] up(‘xs’) should have a min-width of 0px (mui#6735)
70dacf9 
* [breakpoints] up(‘xs’) should have a min-width of 0px

* formatting
@rosskevin rosskevin deleted the breakpoints-up branch May 1, 2017 19:02
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rosskevin @oliviertassinari @muibot @zannager