[Slider] Fix step & max issue #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6750, if the last step is less than half the step size, due to the rounding in the formula to calculate the value in `setValueFromPosition` it is impossible to fill the slider. I resolved this issue by setting the `value` to the `min`/`max` if the cursor is past the respective edges.
oliviertassinari
added
component: slider
oliviertassinari
approved these changes
May 2, 2017
oliviertassinari
changed the title
|
@omarchehab98 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6750, if the last step is less than half the step size, due to the rounding in the formula to calculate the value in
setValueFromPositionit is impossible to fill the slider. I resolved this issue by setting thevalueto themin/maxif the cursor is past the respective edges.I did not write new tests because the problem is specifically related to dragging. Currently, the
Sliderunit tests do not cover mouse actions, I am not experienced enough to write such tests. However, I did test it manually.