Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Start addressing documentation issues #6758

Merged
merged 1 commit into from
May 6, 2017
Merged

[docs] Start addressing documentation issues #6758

merged 1 commit into from
May 6, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 2, 2017 •
edited

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I want to address #6249 and #6246. I'm not there yet.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation next labels May 2, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: Needs Review and removed PR: Needs Review labels May 2, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label May 3, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: Needs Review and removed PR: Needs Review labels May 5, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label May 5, 2017
@muibot muibot added PR: out-of-date The pull request has merge conflicts and can't be merged PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review PR: out-of-date The pull request has merge conflicts and can't be merged labels May 6, 2017
@oliviertassinari oliviertassinari removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: Needs Review labels May 6, 2017
@oliviertassinari oliviertassinari merged commit db90b20 into mui:next May 6, 2017
@oliviertassinari oliviertassinari deleted the docs-style branch May 6, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @rosskevin @muibot