Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Accessibility fix for horizontal rules #6796

Merged
merged 1 commit into from May 6, 2017
Merged

[TextField] Accessibility fix for horizontal rules #6796

merged 1 commit into from May 6, 2017

Conversation

charliegroll
Copy link

@charliegroll charliegroll commented May 6, 2017 •
edited by oliviertassinari

This should resolve #6763, which uses horizontal rules for display purposes under TextFields and shouldn't be read to screen readers.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! PR: Review Accepted and removed PR: Needs Review labels May 6, 2017
@oliviertassinari oliviertassinari changed the title TextField Accessibility fix for horizontal rules [TextField] Accessibility fix for horizontal rules May 6, 2017
@oliviertassinari oliviertassinari merged commit ed94c9c into mui:master May 6, 2017
@oliviertassinari
Copy link
Member

@charliegroll Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charliegroll @oliviertassinari @muibot