Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Handle 0 or 1 rows within the header #6813

Merged
merged 1 commit into from May 9, 2017
Merged

[Table] Handle 0 or 1 rows within the header #6813

merged 1 commit into from May 9, 2017

Conversation

DaIgeb
Copy link
Contributor

@DaIgeb DaIgeb commented May 8, 2017

If passing an array of header rows to the table-header. The table header
will not be rendered if the array is either empty or does contain just
a single item.

Fixes #5322

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@DaIgeb
TableHeader: Handle arrays of length 0 or 1
606bfe2 
If passing an array of header rows to the table-header. The table header
will not be rendered if the array is either empty or does contain just
a single item.

Fixes mui#5322
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module! PR: Review Accepted labels May 8, 2017
@oliviertassinari oliviertassinari changed the title TableHeader: Handle 0 or 1 rows within the header [Table] Handle 0 or 1 rows within the header May 8, 2017
@oliviertassinari oliviertassinari merged commit a74d0b9 into mui:master May 9, 2017
@oliviertassinari
Copy link
Member

@DaIgeb Thanks!

@DaIgeb DaIgeb deleted the tableheader/arraychecks branch May 9, 2017 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaIgeb @oliviertassinari