Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Remove deprecated error and description props #6851

Merged
merged 4 commits into from May 12, 2017
Merged

[Slider] Remove deprecated error and description props #6851

merged 4 commits into from May 12, 2017

Conversation

solkaz
Copy link
Contributor

@solkaz solkaz commented May 12, 2017 •
edited

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fixes #6361
Removes the deprecated description and error props, which were supposed to have been removed in 17.0

Refactored tests as the removal of the description and error elements caused the tests to fail.

@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! PR: Review Accepted and removed PR: Needs Review labels May 12, 2017
@oliviertassinari oliviertassinari merged commit a3979ea into mui:master May 12, 2017
@solkaz solkaz deleted the slider branch May 13, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@solkaz @oliviertassinari @muibot