[Drawer] Fix behavior on RTL layouts #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix swipe to open and close bugs of drawer on RTL layouts
src/Drawer/Drawer.js
Outdated
| @@ -246,7 +246,9 @@ class Drawer extends Component { | |||
| onBodyTouchStart = (event) => { | |||
| const swipeAreaWidth = this.props.swipeAreaWidth; | |||
|
|
|||
| const touchStartX = event.touches[0].pageX; | |||
| const touchStartX = !this.context.muiTheme.isRtl ? | |||
There was a problem hiding this comment.
No need for a negation (!) here and everywhere else in that PR.
There was a problem hiding this comment.
@oliviertassinari Thanks for the review 🙏. Removed unnecessary negations from the code, please let me know if any other changes required.
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
oliviertassinari
approved these changes
May 14, 2017
|
@alireza-ahmadi Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #5603, If you set
isRtl: true, Drawer component swipe to open and close does not work as expected. In fact, a sidebar that located on the right of the screen opens by swiping from the left while it should get opened by swiping from the right. Also, an open drawer can get closed by swiping to the left, while it should get closed by swiping to the right.This pull request applies some minor changes to detect
isRtland change swipe behavior based on that.Please let me know if any changes required.