Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Add false as a valid index value #6945

Merged
merged 1 commit into from May 25, 2017
Merged

[Tabs] Add false as a valid index value #6945

merged 1 commit into from May 25, 2017

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This can be useful when you use the tabs a link navigator and no route is active.

@oliviertassinari oliviertassinari added component: app bar This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module! labels May 24, 2017
@oliviertassinari oliviertassinari added next and removed component: app bar This is the name of the generic UI component, not the React module! labels May 24, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: Needs Review and removed PR: Needs Review labels May 24, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label May 24, 2017
@oliviertassinari oliviertassinari merged commit 352ca60 into mui:next May 25, 2017
@oliviertassinari oliviertassinari deleted the tabs-no-active branch May 25, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliviertassinari @muibot