Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BaseButton] Better handle the disabled property #6958

Merged
merged 1 commit into from May 25, 2017
Merged

[BaseButton] Better handle the disabled property #6958

merged 1 commit into from May 25, 2017

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #6957.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! next and removed PR: Needs Review labels May 25, 2017
@oliviertassinari oliviertassinari merged commit 893c752 into mui:next May 25, 2017
@oliviertassinari oliviertassinari deleted the fix-form-control branch May 25, 2017 19:29
@kybarg
Copy link
Contributor

kybarg commented May 25, 2017 •
edited

@oliviertassinari Thank you so much 👍 Was working on it right now) It took time for me to figure out why passing type prop wasn't working)

@oliviertassinari
Copy link
Member Author

Oh, I should have let you take the lead on that issue!

@kybarg
Copy link
Contributor

kybarg commented May 25, 2017

@oliviertassinari I'm sure you did better job. I only came up with minor fix)

@oliviertassinari oliviertassinari mentioned this pull request May 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] Disabled Button still calling onClick
3 participants
@oliviertassinari @kybarg @muibot