Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Add inputProps property link in the TextField #6959

Merged
merged 1 commit into from May 25, 2017
Merged

[Switch] Add inputProps property link in the TextField #6959

merged 1 commit into from May 25, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 25, 2017 •
edited

Closes #6951 so people can add aria properties to the underlying input or whatever else.
This solution follows what we already have with the TextField/Input components.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module! labels May 25, 2017
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label May 25, 2017
@oliviertassinari oliviertassinari merged commit 95241fb into mui:next May 25, 2017
@oliviertassinari oliviertassinari deleted the fix-switch-properties branch May 25, 2017 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module! PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Switch] aria attributes are not passed to the underlying input component
2 participants
@oliviertassinari @muibot