Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix MuiThemeProvider documentation #6989

Merged
merged 2 commits into from May 29, 2017
Merged

[docs] Fix MuiThemeProvider documentation #6989

merged 2 commits into from May 29, 2017

Conversation

viotti
Copy link
Contributor

@viotti viotti commented May 28, 2017

The theme is no longer available via React context. It can now be obtained via the styleManager object. The docs have been updated.

  • PR has tests / docs demo, and is linted.

There are no new features.

  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".

  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

The theme is no longer available via React context. It can now be
obtained via the styleManager object. The docs have been updated.
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Review Accepted labels May 29, 2017
@mbrookes
Copy link
Member

@oliviertassinari I took advantage if this PR to make some additional minor changes.

@oliviertassinari
Copy link
Member

Well, that's not a good idea to focus the input 😆.
capture d ecran 2017-05-29 a 13 42 49

@oliviertassinari
Copy link
Member

oliviertassinari commented May 29, 2017

@mbrookes Perfect!

@mbrookes
Copy link
Member

Well, that's not a good idea to focus the input

What was that about?

@oliviertassinari
Copy link
Member

@mbrookes Just a failling regression test. That's the first time i'm seeing it. It's flaky but we a low frequency. We can ignore it for now.

@viotti viotti deleted the next branch May 29, 2017 13:20
@oliviertassinari oliviertassinari changed the title [MuiThemeProvider] Fix documentation [docs] Fix MuiThemeProvider documentation Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants