Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add a new site to the showcase #6993

Merged
merged 3 commits into from May 29, 2017

Conversation

wzup
Copy link

@wzup wzup commented May 29, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I have added a new site to a list of sites that use material-ui.
No changes to existing components.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Review Accepted labels May 29, 2017
@wzup
Copy link
Author

wzup commented May 29, 2017

And what's next?
I can't see my project here http://www.material-ui.com/#/discover-more/showcase
I also can't see my changes here docs/src/app/components/pages/discover-more/Showcase.js
When will they appear?

@oliviertasinari We have open-source projects chronologically ordered, but above the rest.
@mbrookes
Copy link
Member

For the code changes to appear, this commit has to be merged. As I have made another change, I will leave it for another maintainer to review and commit. (Back to you @oliviertassinari!)

Then, it won't appear on the docs site until a new release is published and the docs site updated. (approx. every 2 weeks or so).

@oliviertassinari oliviertassinari merged commit 22866a7 into mui:master May 29, 2017
@oliviertassinari oliviertassinari changed the title Adds a new site that uses Material-UI [docs] Add a new site to the showcase Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants