Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve accessibility in the component examples #7047

Merged
merged 6 commits into from
Jun 3, 2017

Conversation

tuukkao
Copy link

@tuukkao tuukkao commented Jun 3, 2017

  • Added labels to the unlabeled IconButtons.
  • Added aria-expanded to one of the Card example buttons to signify that the button in question expands the contents of the card.

The labels are intended to convey the meaning of the button rather than to describe the icons themselves. Please let me know if some of these labels seem incorrect.

Closes #6956.

  • PR has tests / docs demo, and is linted. (I got 67 linting errors in the unmodified next branch alone. Is this expected to be broken in next?)
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari merged commit b5fbcfb into mui:next Jun 3, 2017
@oliviertassinari oliviertassinari added accessibility a11y docs Improvements or additions to the documentation next labels Jun 3, 2017
@oliviertassinari
Copy link
Member

@tuukkao Thank you :)

@oliviertassinari oliviertassinari changed the title Improve accessibility in the component examples [docs] Improve accessibility in the component examples Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add missing aria-labels and other semantics to code examples to promote best practices
2 participants