New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Add a keepMounted property #7072

Merged

oliviertassinari merged 1 commit into mui:next from oliviertassinari:drawer-keep-in-dom

Jun 8, 2017

Member

oliviertassinari commented Jun 7, 2017 •

edited

So we have the top level information in the index of the search provided by Algolia:
That should result in a much better search experience.

Expected

Actual

So we maximise the responsiveness of the Drawer in the documentation. We save around 100ms by using the keepMounted option on a high-end device. That should definitely be perceivable by any user. @nathanmarks That's something we have been discussing a long time ago :).

Before

After

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).


          [Modal] Add a keepMounted property

8a04065

oliviertassinari added new feature next labels

oliviertassinari merged commit 62f6801 into mui:next

oliviertassinari deleted the drawer-keep-in-dom branch

June 8, 2017 07:56

oliviertassinari mentioned this pull request

Fix for alpha docs site #7387

Closed

oliviertassinari mentioned this pull request

Slide component adds hardcoded 24px gutter #16499

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment