Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListItemText] Add disableTypography property #7073

Merged
merged 2 commits into from
Jun 7, 2017
Merged

[ListItemText] Add disableTypography property #7073

merged 2 commits into from
Jun 7, 2017

Conversation

zachwolf
Copy link
Contributor

@zachwolf zachwolf commented Jun 7, 2017 •
edited by oliviertassinari

Closes #7067

Description

ListItemText previously always wrapped the props.children with a Typography component. This PR adds functionality to make the wrapper component conditional.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari changed the title [ListItemText] Adds disableTypography prop [ListItemText] Add disableTypography property Jun 7, 2017
@oliviertassinari oliviertassinari merged commit 4325c75 into mui:next Jun 7, 2017
@oliviertassinari
Copy link
Member

@zachwolf Thank you

@zannager zannager added the component: list This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ListItemText] Text styles are being overruled by unexposed Typography component styles
3 participants
@zachwolf @oliviertassinari @zannager