Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormHelperText] Add a min-height #7085

Merged
merged 1 commit into from
Jun 8, 2017
Merged

[FormHelperText] Add a min-height #7085

merged 1 commit into from
Jun 8, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 8, 2017

Add a min-height as the flexbox layout with wrap mode might not be enough.
One might want to do the following the get his text-fields with a consistent height even when one field has an helper text:

<TextField
  id="name"
  label="Name"
  value={this.state.name}
  onChange={event => this.setState({ name: event.target.value })}
  helperText="helperText"
/>
<TextField
  id="uncontrolled"
  label="Uncontrolled"
  defaultValue="foo"
  className={classes.input}
  helperText={<span />}
/>

capture d ecran 2017-06-08 a 20 07 23

Closes #7068

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! next labels Jun 8, 2017
@oliviertassinari oliviertassinari merged commit 9db07ee into mui:next Jun 8, 2017
@oliviertassinari oliviertassinari deleted the text-field-helper-text-height branch June 8, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextField] FormHelperText and height implication
1 participant