[Tab] Support SVG Icons color #7091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RejinR Isn't that a breaking change? Following our ROADMAP, I'm not sure we want to go forward with that PR. We focus on bug fixes for the master branch as we migrated our effort to the next branch. |
oliviertassinari
added
the
component: tabs
oliviertassinari
changed the title
|
I've added conditions to avoid breaking now.. |
oliviertassinari
approved these changes
Jun 10, 2017
|
@RejinR Thanks! |
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG icons color style is not being used in the tab even though the comment before the line says it takes the color style if it's SVG icon.