[TextField] Replaced WebkitTextFillColor with WebkitOpacity #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midan888
changed the title
src/TextField/TextField.js
Outdated
| @@ -57,7 +57,7 @@ const getStyles = (props, context, state) => { | |||
| color: props.disabled ? disabledTextColor : textColor, | |||
| cursor: 'inherit', | |||
| font: 'inherit', | |||
| WebkitTextFillColor: props.disabled ? disabledTextColor : textColor, | |||
| WebkitOpacity: props.disabled ? 1 : null, | |||
There was a problem hiding this comment.
I think that it can be as simple as WebkitOpacity: 1.
…xtFillColor overwrites any custom html color rules
oliviertassinari
approved these changes
Jun 9, 2017
oliviertassinari
added
PR: Review Accepted
component: text field
|
@midan888 Thanks |
|
@oliviertassinari When will this be merged into a release? (0.18.4) |
|
Will do a release by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebkitTextFillColor overwrites any custom html css color rules