Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Normalize the API #7099

Merged
merged 1 commit into from
Jun 11, 2017
Merged

[core] Normalize the API #7099

merged 1 commit into from
Jun 11, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 10, 2017

  • Reduce degree of freedom of the API with the color property. That's a tradeoff between correctness and verbosity.
    People should be able to recover from that breaking change quite easily as react is going to throw warnings.
  • Transform all the classes to be camelCase (consistency)
  • Use @owencm trick with double RAF to fix an animation issue with Chrome v59
  • Fix animation with the older browsers like iOS 8.
  • Add new tests to the Chip, withWidth, Textarea, ListItem +0.58%

@mbrookes
Copy link
Member

I'm on board with the changes in principal, and gave it a quick scan. Too many changed files to review it thoroughly! 😆

@oliviertassinari oliviertassinari merged commit 597bf6f into mui:next Jun 11, 2017
@oliviertassinari oliviertassinari deleted the normalize-API branch June 11, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants