Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drawer] Remove event listeners on unmount #7225

Merged
merged 1 commit into from Jun 23, 2017
Merged

[Drawer] Remove event listeners on unmount #7225

merged 1 commit into from Jun 23, 2017

Conversation

liamcmitchell
Copy link

@liamcmitchell liamcmitchell commented Jun 23, 2017 •
edited by oliviertassinari

Should fix error TypeError: undefined is not an object (evaluating 'this.refs.overlay.setOpacity') that can happen if the Drawer is unmounted in the middle of a touch interaction.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work PR: Review Accepted component: drawer This is the name of the generic UI component, not the React module! labels Jun 23, 2017
@oliviertassinari oliviertassinari merged commit e940608 into mui:master Jun 23, 2017
@oliviertassinari
Copy link
Member

@liamcmitchell thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liamcmitchell @oliviertassinari @liamcmitchell-sc