Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Expand use of flow #7268

Merged
merged 10 commits into from Jun 27, 2017
Merged

[core] Expand use of flow #7268

merged 10 commits into from Jun 27, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Jun 27, 2017

Annotate more files with flow.

squash+merge

Closes #7271


  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@rosskevin
Copy link
Member Author

test:coverage: had this error previous to changes:

  1) <MuiThemeProvider /> server side should be able to extract the styles:
     
  NotFoundError
      at HTMLHeadElementImpl.insertBefore (node_modules/jsdom/lib/jsdom/living/nodes/Node-impl.js:208:17)
      at HTMLHeadElement.insertBefore (node_modules/jsdom/lib/jsdom/living/generated/Node.js:131:45)
      at DomRenderer.attach (node_modules/jss/lib/backends/DomRenderer.js:220:17)
      at StyleSheet.attach (node_modules/jss/lib/StyleSheet.js:64:21)
      at renderNew (node_modules/jss-theme-reactor/styleManager.js:151:47)
      at Object.render (node_modules/jss-theme-reactor/styleManager.js:94:14)
      at Style.render (src/styles/withStyles.js:25:57)
      at node_modules/react-dom/lib/ReactCompositeComponent.js:795:21
      at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:75:12)
      at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (node_modules/react-dom/lib/ReactCompositeComponent.js:794:25)
      at ReactCompositeComponentWrapper._renderValidatedComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:821:32)
      at ReactCompositeComponentWrapper.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:361:30)
      at ReactCompositeComponentWrapper.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:257:21)
      at Object.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:45:35)
      at ReactCompositeComponentWrapper.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:370:34)
      at ReactCompositeComponentWrapper.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:257:21)
      at Object.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:45:35)
      at node_modules/react-dom/lib/ReactServerRendering.js:45:36
      at ReactServerRenderingTransaction.perform (node_modules/react-dom/lib/Transaction.js:143:20)
      at renderToStringImpl (node_modules/react-dom/lib/ReactServerRendering.js:43:24)
      at renderToString (node_modules/react-dom/lib/ReactServerRendering.js:73:10)
      at Context.<anonymous> (src/styles/MuiThemeProvider.spec.js:36:22)

I filed a new issue, because test:unit succeeds while test:coverage fails.

@rosskevin rosskevin merged commit 6376695 into mui:next Jun 27, 2017
@rosskevin rosskevin deleted the flow-more branch June 27, 2017 18:37
@oliviertassinari
Copy link
Member

We miss the test coverage. Something is wrong here.

@rosskevin rosskevin restored the flow-more branch June 27, 2017 18:50
@rosskevin
Copy link
Member Author

I'll follow this up in the still open #7271

@rosskevin rosskevin deleted the flow-more branch June 27, 2017 18:52
@oliviertassinari oliviertassinari changed the title Expand use of flow [core] Expand use of flow Jul 4, 2017
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test:coverage yields errors even though test:unit succeeds
3 participants