[ListItem] Fix triggers onTouchTap when disabled #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Jul 20, 2017
There was a problem hiding this comment.
The fix could be a one line change:
render() {
const {
autoGenerateNestedIndicator,
children,
containerElement,
disabled,
disableKeyboardFocus,
hoverColor, // eslint-disable-line no-unused-vars
initiallyOpen, // eslint-disable-line no-unused-vars
innerDivStyle,
insetChildren, // eslint-disable-line no-unused-vars
leftAvatar,
leftCheckbox,
leftIcon,
nestedItems,
nestedLevel,
nestedListStyle,
onKeyboardFocus, // eslint-disable-line no-unused-vars
isKeyboardFocused, // eslint-disable-line no-unused-vars
onMouseEnter, // eslint-disable-line no-unused-vars
onMouseLeave, // eslint-disable-line no-unused-vars
onNestedListToggle, // eslint-disable-line no-unused-vars
onTouchStart, // eslint-disable-line no-unused-vars
+ onTouchTap, // eslint-disable-line no-unused-vars
rightAvatar,
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
|
you are right. Do you want me to open a new PR with only one commit? regards |
|
As you prefer, I will squash the commits if needed. |
oliviertassinari
approved these changes
Jul 21, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
|
@jonashartwig Thanks |
|
@oliviertassinari |
|
@hwo411 True, I just thought it's inoffensive to have that logic. |
|
yes, but then it does not change anything, it will send all values that are falsey as disabled then. Is it supposed to be fixed? I dont think it will break anything |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Jul 24, 2017
* call_em_all_-_master/master: fix: comment typo (mui#7523) [Docs] Add v0.18.7 to versions.json v0.18.7 [CHANGELOG] Prepare v0.18.7 [ListItem] Fix triggers onTouchTap when disabled (mui#7486) [Popover] Scroll Container issue (mui#7472) [Table] Don't set height to tbody (mui#7484) docs: fix typo in Avatar readme (mui#7478) # Conflicts: # src/Popover/Popover.js # merged both versions
adam187
added a commit
to adam187/material-ui
that referenced
this pull request
Nov 21, 2017
…om-build * fix/broken-touch-scroll-on-nested-menu-items: [Menu] Ignore loosing focus on click away for item with menu items [examples] Remove browserify Fixes mui#7559 (mui#7560) [docs] Update ROADMAP (mui#7543) [Table] Row click on empty cell to not die in IE (mui#7520) Internal(EnhancedSwitch): fix checked prop (mui#7499) fix: comment typo (mui#7523) [Docs] Add v0.18.7 to versions.json v0.18.7 [CHANGELOG] Prepare v0.18.7 [ListItem] Fix triggers onTouchTap when disabled (mui#7486) [Popover] Scroll Container issue (mui#7472) [Table] Don't set height to tbody (mui#7484) docs: fix typo in Avatar readme (mui#7478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it was forgotten to send disabled to EnhancedButton as it has internal logic to not trigger onTouchTap if disabled is set to true.
Closes #7449.