Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Some fixes after the latest upgrade #7528

Merged
merged 1 commit into from Jul 24, 2017
Merged

[docs] Some fixes after the latest upgrade #7528

merged 1 commit into from Jul 24, 2017

Conversation

oliviertassinari
Copy link
Member

Closes #7524.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 24, 2017
@oliviertassinari oliviertassinari merged commit 6864a8c into mui:v1-beta Jul 24, 2017
@oliviertassinari oliviertassinari deleted the docs-fixes branch July 24, 2017 14:50
@stunaz
Copy link
Contributor

stunaz commented Jul 24, 2017

@oliviertassinari been reviewed your changes, I cant see how it fixes #7524. Yes the demo would be fixed, but not the functionnality (fullScreen) itself.

@oliviertassinari
Copy link
Member Author

Opps, you are right!

@oliviertassinari
Copy link
Member Author

Let's revert

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 24, 2017 •
edited

Thanks for catching it

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 24, 2017 •
edited

Done 4deee4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliviertassinari @stunaz