Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Minor tweaks to grammar of CSS in JS page #7530

Merged
merged 2 commits into from Jul 24, 2017
Merged

[docs] Minor tweaks to grammar of CSS in JS page #7530

merged 2 commits into from Jul 24, 2017

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jul 24, 2017 •
edited by oliviertassinari

I wasn't sure about a couple of these, where fixing the grammar may have inadvertently changed the meaning!

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@mbrookes
[Docs] Monor tweaks to grammar of CSS in JS page
8e8f27c 
I wasn't sure about a couple of these, where fixing the grammar may have inadvertently changed the meaning!
@mbrookes mbrookes changed the title [Docs] Monor tweaks to grammar of CSS in JS page [Docs] Minor tweaks to grammar of CSS in JS page Jul 24, 2017
@oliviertassinari
Copy link
Member

🎉

oliviertassinari
oliviertassinari reviewed Jul 24, 2017
View reviewed changes
docs/src/pages/customization/css-in-js.md Outdated
- It's forwarding not react static properties so this HOC is more "transparent".

Some implementation details that might be interesting to being aware of:
- It's not forwarding react static properties so this HOC is more "transparent".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it should be the opposite as we are using https://github.com/mridgway/hoist-non-react-statics
It's forwarding non react static properties so this HOC is more "transparent".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake was using not over non.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, perfect, that was the one I was must unsure about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v1 labels Jul 24, 2017
@oliviertassinari oliviertassinari merged commit 9547ee9 into v1-beta Jul 24, 2017
@oliviertassinari oliviertassinari deleted the mbrookes-patch-1 branch July 24, 2017 19:43
@oliviertassinari oliviertassinari changed the title [Docs] Minor tweaks to grammar of CSS in JS page [docs] Minor tweaks to grammar of CSS in JS page Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbrookes @oliviertassinari