Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] remove extraneous props when using custom component #7784

Merged
merged 1 commit into from Aug 16, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Aug 16, 2017

Fixes #7772

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@rosskevin rosskevin changed the title [Input] remove extraneous props when using custom component, Fixes #7772 [Input] remove extraneous props when using custom component Aug 16, 2017
@rosskevin rosskevin added v1 bug 🐛 Something doesn't work labels Aug 16, 2017
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't try this change right now as in the middle of a documentation rewrite of the infrastructure, but that looks good. Have you tried interacting with the demos?

@rosskevin
Copy link
Member Author

No, tests pass and I found zero usages of input with custom component. I'm out now so I can't check anything probably until tomorrow.

@rosskevin rosskevin merged commit 4617324 into mui:v1-beta Aug 16, 2017
@rosskevin rosskevin deleted the input-component-fix branch August 16, 2017 21:04
@leoliu
Copy link

leoliu commented Aug 17, 2017

there are a few dozens of new entries to yarn.lock? What are they for?

@rosskevin
Copy link
Member Author

I ran yarn because my local install was out of date. The package.json was unchanged so it should be of no consequence (and all tests pass). I have no idea why the lock ultimately changed, but I trust yarn to do that diff as well as our tests.

@rosskevin
Copy link
Member Author

I figured this out. The Greenkeeper bot merges in changes but the yarn.lock isn't updated. Whenever one of us runs yarn locally, we'll see this reflected in the lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants