Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Update <Slide> typings #7817

Merged
merged 1 commit into from Aug 18, 2017
Merged

[typescript] Update <Slide> typings #7817

merged 1 commit into from Aug 18, 2017

Conversation

sebald
Copy link
Member

@sebald sebald commented Aug 18, 2017

Ref #7808

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@sebald
Copy link
Member Author

sebald commented Aug 18, 2017

@oliviertassinari This is not really essential or super important. But could you approve and merge this before the next beta, pretty please :)

@oliviertassinari oliviertassinari merged commit a3ac25b into v1-beta Aug 18, 2017
@oliviertassinari oliviertassinari deleted the typings-update-slide branch August 18, 2017 08:52
@oliviertassinari oliviertassinari changed the title [typings] Update <Slide> typings [typescript] Update <Slide> typings Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebald @oliviertassinari @zannager