Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Create typings for material-ui-icons #7820

Merged
merged 1 commit into from Aug 18, 2017

Conversation

sebald
Copy link
Member

@sebald sebald commented Aug 18, 2017

Added a script that runs when the packages is build and creates typings for all the icons.
Note that there is currently no index created, you have to import things the tree-shakable way (import Apps from 'material-ui-icons/Apps';).

Closes #7816


  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari merged commit f8846d9 into v1-beta Aug 18, 2017
@oliviertassinari oliviertassinari deleted the typings-for-icons branch August 18, 2017 10:17
@oliviertassinari
Copy link
Member

I will release it later in the day.

@oliviertassinari oliviertassinari changed the title [typescript] Create typings for TS when building. [typescript] Create typings for TS when building Aug 20, 2017
@oliviertassinari oliviertassinari changed the title [typescript] Create typings for TS when building [typescript] Create typings for material-ui-icons Aug 20, 2017
oliviertassinari pushed a commit that referenced this pull request Aug 23, 2017
* [typescript] Add test for style overrides.

* [typescript] Refactor typings to modules

...instead of ambient modules.

* renamed the styleSheet argument in withStyles to styles (#7819)

* [typescript] Create typings for TS when building. (#7820)

* [core] Fix size-limit warning (#7822)

* [icons] Automate release process (#7823)

* [docs] Advanced table (#7824)

* [icons] Fix release

* [icons] Release v1.0.0-beta.5

* [core] Update some dependencies (#7831)

* [icons] Update the dependencies

* [core] Update some dependencies

* [docs] Use next.js (#7759)

* [RadioGroup] Rename selectedValue to value (#7832)

* [core] Better usage of the CI 🚀 (#7833)

* [TextField] Fix placeholder issue (#7838)

* [docs] Add a ROADMAP page (#7840)

* [docs] Add a team page (#7842)

* [docs] Show inherited components (#7846)

* [docs] Some last improvement before the release (#7847)

* [CHANGELOG] Prepare v1.0.0-beta.6

* v1.0.0-beta.6

* [docs] Fix release script

* [docs] Fix release script v2

* [docs] Small fixes after the next.js refactorization (#7851)

* [docs] Fix missing props in css-in-js examples (#7867)

* [docs] Fix missing props in css-in-js examples

`this.classes.root` wouldn't work - `this.props.classes.root' would.

* Update css-in-js.md

* [typescript] Fix tests.

* [build] Copy .d.ts files to build folder.

* [typescript] Create module typings for icons.

* [typescript] Lint.
Taldrain pushed a commit to Taldrain/material-ui that referenced this pull request Aug 24, 2017
* [typescript] Add test for style overrides.

* [typescript] Refactor typings to modules

...instead of ambient modules.

* renamed the styleSheet argument in withStyles to styles (mui#7819)

* [typescript] Create typings for TS when building. (mui#7820)

* [core] Fix size-limit warning (mui#7822)

* [icons] Automate release process (mui#7823)

* [docs] Advanced table (mui#7824)

* [icons] Fix release

* [icons] Release v1.0.0-beta.5

* [core] Update some dependencies (mui#7831)

* [icons] Update the dependencies

* [core] Update some dependencies

* [docs] Use next.js (mui#7759)

* [RadioGroup] Rename selectedValue to value (mui#7832)

* [core] Better usage of the CI 🚀 (mui#7833)

* [TextField] Fix placeholder issue (mui#7838)

* [docs] Add a ROADMAP page (mui#7840)

* [docs] Add a team page (mui#7842)

* [docs] Show inherited components (mui#7846)

* [docs] Some last improvement before the release (mui#7847)

* [CHANGELOG] Prepare v1.0.0-beta.6

* v1.0.0-beta.6

* [docs] Fix release script

* [docs] Fix release script v2

* [docs] Small fixes after the next.js refactorization (mui#7851)

* [docs] Fix missing props in css-in-js examples (mui#7867)

* [docs] Fix missing props in css-in-js examples

`this.classes.root` wouldn't work - `this.props.classes.root' would.

* Update css-in-js.md

* [typescript] Fix tests.

* [build] Copy .d.ts files to build folder.

* [typescript] Create module typings for icons.

* [typescript] Lint.
@sebald sebald mentioned this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants