Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Expose the component #7927

Merged
merged 1 commit into from
Aug 26, 2017
Merged

[Popover] Expose the component #7927

merged 1 commit into from
Aug 26, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 26, 2017

Closes #6270 : Add some documentation and move the component to the public API
Closes #7573, #7426 : Block the scroll of the body, we are screwed when used inside a scrollable container that isn't the body. This is a limitation of the component. We would have to use react-popper to fix it.
Closes #7440 : Looks good now
Closes #7015 : Hops it's fine with this rewrite
Closes #7012 : We are no longer listening for the onWheel event
Closes #4439 : Hops it's fine with this rewrite

aout-27-2017 00-24-03


  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added component: Popover The React component. new feature New feature or request v1 labels Aug 26, 2017
@oliviertassinari oliviertassinari merged commit b4ca64b into mui:v1-beta Aug 26, 2017
@oliviertassinari oliviertassinari deleted the popover-docs branch August 26, 2017 22:55
sebald pushed a commit that referenced this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant