[CardMedia] Guard against null children and overlays #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Sep 5, 2017
|
@AlexMayants Thanks. |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Sep 14, 2017
* call_em_all_-_master/master: [EnhancedButton] -- Prevent href being overwritten by undefined. (mui#8103) [CardMedia] Guard against null children and overlays (mui#8055) [Docs] Add v0.19.1 to versions.json v0.19.1 [CHANGELOG] Prepare v0.19.1 Have the InkBar in the Tabs component honor the value prop (mui#8010) [AutoComplete] Fix bug where controlled component behaves uncontrolled. (mui#7967) stop preventing event default on iconmenu open (mui#7933) Fix PopOver animation origin when horizontal=middle (mui#7930) [Slider] Resolve slider value to respect max and min (mui#7863) Update onNewRequest documentation to explain chosenRequest returns dataSource value. (mui#7835) [Docs] Add v0.19.0 to versions.json v0.19.0 [CHANGELOG] Prepare v0.19.0 [core] Add react^16.0.0-beta.5 in peer dependencies [DatePicker] Fixed bug where 'isSelectedDateDisabled' was returning undefined (mui#7735) Create CODE_OF_CONDUCT.md (mui#7704) Update related projects. (mui#7706) # Conflicts: # src/internal/EnhancedButton.js
|
Hi @oliviertassinari, if you don't mind asking, when do you plan to publish a new release including this PR? |
|
Today. |
|
Great to know, thanks! |
zannager
added
the
component: card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CardMedia with
actAsExpanderprop set to true throws an exception here https://github.com/callemall/material-ui/blob/master/src/Card/CardMedia.js#L110 because Card adds anundefinedchild to it if there's noshowExpandableButton.This PR fixes the issue by checking whether a child is empty.