[Input] Better handle type=number #8164

oliviertassinari · 2017-09-12T11:26:22Z

Fix server-side rendering issue
Improve type number display on Firefox
Add a type search example
I wish I had a better solution for [TextField] used type="number" label will not stay floated if non numeric values are entered #8155 but I don't, the change event isn't triggered. I have provided reproduction examples on the related react issue: Number input not firing onChange facebook/react#10370 (comment). Of course, we could have been running the dirty check at each key down events, but I don't want to harm 80% of the use cases for 20% of this one. This extra checks could increase the feedback latency to users on an input. This is not something I want to risk.

oliviertassinari · 2017-09-12T11:33:58Z

docs/src/modules/components/Demo.js

@@ -74,7 +75,9 @@ class Demo extends React.Component<any, any> {
          <CodeIcon />
        </IconButton>
        <Collapse in={this.state.codeOpen}>
-          <MarkdownElement className={classes.code} text={`\`\`\`js\n${raw}\n\`\`\``} />
+          <NoSSR>
+            <MarkdownElement className={classes.code} text={`\`\`\`js\n${raw}\n\`\`\``} />


Speed up the time to first paint. This part isn't visible and needs the page to be interactive to be shown.

oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! v1 labels Sep 12, 2017

oliviertassinari commented Sep 12, 2017

View reviewed changes

[Input] Better handle type=number

aa24680

oliviertassinari merged commit 23e9177 into mui:v1-beta Sep 12, 2017

oliviertassinari deleted the fix-text-field-number branch September 12, 2017 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Input] Better handle type=number #8164

[Input] Better handle type=number #8164

oliviertassinari commented Sep 12, 2017

oliviertassinari Sep 12, 2017

[Input] Better handle type=number #8164

[Input] Better handle type=number #8164

Conversation

oliviertassinari commented Sep 12, 2017

oliviertassinari Sep 12, 2017

Choose a reason for hiding this comment