[typescript] Update BreakpointsOptions in createBreakpoints
#8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch recent change to API
oliviertassinari
approved these changes
Sep 25, 2017
src/styles/createBreakpoints.d.ts
Outdated
| @@ -3,7 +3,7 @@ export type BreakpointMap = { [key in Breakpoint]: number }; | |||
| export const keys: Breakpoint[]; | |||
|
|
|||
| export interface BreakpointsOptions { | |||
| breakpointsMap: BreakpointMap; | |||
| values: BreakpointMap; | |||
There was a problem hiding this comment.
Should we rename the BreakpointMap too?
|
@oliviertassinari Ok yes, that might make it easier to understand. PR updated. |
|
@peterprice Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match recent change to API