[docs] Select API default value for input prop #8385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markdown was being rendered as an actual input field - left angle bracket needed to be `<`
|
🤣
|
oliviertassinari
requested changes
Sep 25, 2017
| @@ -10,7 +10,7 @@ | |||
| | MenuProps | Object | | Properties applied to the `Menu` element. | | |||
| | <span style="color: #31a148">children *</span> | ChildrenArray | | The option elements to populate the select with. Can be some `MenuItem` when `native` is false and `option` when `native` is true. | | |||
| | classes | Object | | Useful to extend the style applied to components. | | |||
| | input | Element | <Input /> | An `Input` element. | | |||
| | input | Element | <Input /> | An `Input` element. | | |||
There was a problem hiding this comment.
This is automatically generated, but follow a pattern close can help.
https://github.com/callemall/material-ui/blob/353f64d896eca71399c1e97a5c02d3ed5d78050c/docs/src/modules/utils/generateMarkdown.js#L42
There was a problem hiding this comment.
I'll take care of it when parsing the default value
oliviertassinari
added
PR: needs revision
…eplace left angle bracket with < - Select input prop - Checkbox indeterminateIcon
oliviertassinari
approved these changes
Sep 25, 2017
oliviertassinari
removed
the
PR: needs revision
|
👌✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown was being rendered as an actual input field on the doc site and not at all when viewed on github. Left angle bracket needs to be
<(as mentioned on gruber's syntax docs)