Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add FormDialog Example #8411

Merged
merged 3 commits into from Sep 27, 2017
Merged

[docs] Add FormDialog Example #8411

merged 3 commits into from Sep 27, 2017

Conversation

chaseWillden
Copy link
Contributor

When going through the new docs to implement the project in my personal app, I thought that a forms dialog example would be helpful.

@oliviertassinari oliviertassinari changed the title Add FormDialog Example [docs] Add FormDialog Example Sep 27, 2017
@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation v1 labels Sep 27, 2017
oliviertassinari
oliviertassinari approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be covered by the specification, but I agree, I can be very useful. For instance, Firebase is relying on many dialogs like this one.

capture d ecran 2017-09-27 a 09 06 03

@oliviertassinari oliviertassinari merged commit ed53299 into mui:v1-beta Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chaseWillden @oliviertassinari