Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typography] Add primary option to color property #8440

Merged
merged 2 commits into from Sep 28, 2017

Conversation

eyn
Copy link
Contributor

@eyn eyn commented Sep 28, 2017

No description provided.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the typescript definition too? :)

@oliviertassinari oliviertassinari added v1 PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Sep 28, 2017
@eyn
Copy link
Contributor Author

eyn commented Sep 28, 2017

I think (by chance!!) it is already included:

export interface TypographyProps extends React.HTMLAttributes<HTMLElement> {
  align?: PropTypes.Alignment;
  component?: React.ReactType;
  color?: PropTypes.Color | 'secondary';
  gutterBottom?: boolean;
  headlineMapping?: { [type in TextStyle]: string };
  noWrap?: boolean;
  paragraph?: boolean;
  type?: Style | 'caption' | 'button';
}
export namespace PropTypes {
  type Alignment = 'inherit' | 'left' | 'center' | 'right' | 'justify';
  type Color = 'inherit' | 'primary' | 'accent' | 'default';
  type Margin = 'none' | 'dense' | 'normal';
}

@oliviertassinari oliviertassinari added PR: accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Sep 28, 2017
@oliviertassinari oliviertassinari merged commit f6cbc21 into mui:v1-beta Sep 28, 2017
@oliviertassinari
Copy link
Member

@eyn Thanks

@eyn eyn deleted the add-primary-to-typography branch September 28, 2017 16:09
@oliviertassinari oliviertassinari changed the title [Typography] Add primary option to color prop [Typography] Add primary option to color property Sep 30, 2017
@zannager zannager added the component: Typography The React component. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Typography The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants